Add support type and Demographic on MangaListFilter #1061
Conversation
| @@ -0,0 +1,10 @@ | |||
| package org.koitharu.kotatsu.parsers.model | |||
|
|
|||
| enum class Type { | |||
There was a problem hiding this comment.
Let's rename it something more specific, e.g. MangaType?
There was a problem hiding this comment.
I don't think so, because MangaType.Manga is duplicated
and logically manga refers to the type of Japanese work.
There was a problem hiding this comment.
Yes but Type is a very generic and commonly used name:
There was a problem hiding this comment.
hum ok, go for MangaType, I can't think of any other name that would be clear to understand
There was a problem hiding this comment.
After that, I was thinking of a "BookType", but I'm not sure that's more relevant.
There was a problem hiding this comment.
As an option we can merge this with a ContentType class and use this name
There was a problem hiding this comment.
Yes, it's ideal, but you shouldn't add tabs to the App (especially for novel manhua, other ect).
Co-authored-by: Koitharu <[email protected]>
Co-authored-by: Koitharu <[email protected]>
Yet another addition, I'm separating the requests so that I don't have to add everything at once.
For the type, I didn't use contentype, because it seems to me that it's linked to the tab on the app.