Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new filter on MangaListFilter.Advanced #1054

Merged
merged 4 commits into from
Sep 14, 2024

Conversation

davvarrr
Copy link
Collaborator

@davvarrr davvarrr commented Sep 10, 2024

Not many sources have the option to do a text search with filters, but it would be nice to add it.
(I haven't looked at all the ones that do, but at least the option will be there)

I've also added other filters, not necessarily from many sources, but it's always good to have them anyway.
I've looked at adding author too, but in some cases the source just asks for text and others like mangedex have an id for that so I don't know if it would be good to add it or not and above all how (on text or like tags or a mixture of the 2 with a default option to enter text and if there is an existing list, it is displayed).
(The same logic applies if you add the artist filter).

The sorting filters have been added to make it easier to search via text and to differentiate between sorting by the date the manga was added and the date of publication.

And you can see to add the filters ask here : #583
Because quite a few +18 sources and others like bato use them.
The logic would be ‘POPULARITY’ for all time
and the others on a low time so taking bato as an example
POPULARITY_LAST_HOUR
POPULARITY_TODAY
POPULARITY_WEEK
POPULARITY_MONTH
POPULARITY_YEAR
In case I've made a proposal other than this one #1055

close #941
close #662

Add query.filer Advanced on MangaDexParser
Add year, localeMangas and localeMangas on MangaDexParser
@davvarrr davvarrr changed the title Add query filter on MangaListFilter.Advanced Add new filter on MangaListFilter.Advanced Sep 10, 2024
@Koitharu Koitharu changed the base branch from master to feature/advanced_filter September 14, 2024 09:28
@Koitharu Koitharu merged commit 494ecdf into feature/advanced_filter Sep 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MangaDex Original Language Filter and Latest (basically enhanced Updated) sorting order. Filter on sources
2 participants