Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add getSunLowerTransit algorithm to detect solar midnight #234

Merged
merged 2 commits into from
Apr 26, 2024
Merged

add getSunLowerTransit algorithm to detect solar midnight #234

merged 2 commits into from
Apr 26, 2024

Conversation

pinnymz
Copy link
Contributor

@pinnymz pinnymz commented Apr 16, 2024 •
edited
Loading

The new getSunLowerTransit method will find the sun transit time on the opposite side of the earth: longitudinal offset by 180 degrees.

As part of this PR, the internal getDateFromTime conversion method has been enhanced to support additional solar events. To this end, the boolean isSunrise has been changed to an enum.

KosherJava
KosherJava approved these changes Apr 26, 2024
View reviewed changes
Copy link
Owner

@KosherJava KosherJava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pinnymz

@KosherJava KosherJava merged commit a76a3b6 into KosherJava:master Apr 26, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KosherJava KosherJava KosherJava approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pinnymz @KosherJava