Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(entityemptystate): added appreance prop support [KHCP-14905] #1919

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

afrzhussain
Copy link

@afrzhussain afrzhussain commented Jan 30, 2025

Summary
JIRA : https://konghq.atlassian.net/browse/KHCP-14905

  • Added appearance prop with 'primary' and 'secondary' options to support L2 empty states. The secondary appearance has a slightly smaller title font size.
  • Fixed feature cards taking up unnecessary space when features are empty.

@afrzhussain afrzhussain requested review from a team as code owners January 30, 2025 12:11
@CLAassistant
Copy link

CLAassistant commented Jan 30, 2025

CLA assistant check
All committers have signed the CLA.

kaiarrowood
kaiarrowood previously approved these changes Jan 31, 2025
Copy link
Contributor

@kaiarrowood kaiarrowood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@kaiarrowood kaiarrowood dismissed stale reviews from adamdehaven and themself January 31, 2025 16:17

Issues addressed

Copy link
Contributor

@kaiarrowood kaiarrowood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@kongponents-bot
Copy link
Collaborator

Preview components from this PR in consuming application

In consuming application project install preview versions of shared packages generated by this PR:

@kong-ui-public/entities-shared@pr-1919
@kong-ui-public/dashboard-renderer@pr-1919
@kong-ui-public/documentation@pr-1919
@kong-ui-public/tracing@pr-1919
@kong-ui-public/entities-certificates@pr-1919
@kong-ui-public/entities-consumer-credentials@pr-1919
@kong-ui-public/entities-consumer-groups@pr-1919
@kong-ui-public/entities-consumers@pr-1919
@kong-ui-public/entities-data-plane-nodes@pr-1919
@kong-ui-public/entities-gateway-services@pr-1919
@kong-ui-public/entities-key-sets@pr-1919
@kong-ui-public/entities-keys@pr-1919
@kong-ui-public/entities-routes@pr-1919
@kong-ui-public/entities-snis@pr-1919
@kong-ui-public/entities-upstreams-targets@pr-1919
@kong-ui-public/entities-vaults@pr-1919
@kong-ui-public/entities-plugins@pr-1919

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants