-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(entityemptystate): added appreance prop support [KHCP-14905] #1919
Open
afrzhussain
wants to merge
6
commits into
main
Choose a base branch
from
feat/KHCP-14905-add-appearance-in-entity-empty-state
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(entityemptystate): added appreance prop support [KHCP-14905] #1919
afrzhussain
wants to merge
6
commits into
main
from
feat/KHCP-14905-add-appearance-in-entity-empty-state
+49
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamdehaven
previously requested changes
Jan 30, 2025
packages/entities/entities-shared/src/components/entity-empty-state/EntityEmptyState.vue
Outdated
Show resolved
Hide resolved
packages/entities/entities-shared/src/components/entity-empty-state/EntityEmptyState.vue
Outdated
Show resolved
Hide resolved
packages/entities/entities-shared/src/types/entity-empty-state.ts
Outdated
Show resolved
Hide resolved
packages/entities/entities-shared/src/components/entity-empty-state/EntityEmptyState.vue
Outdated
Show resolved
Hide resolved
kaiarrowood
reviewed
Jan 30, 2025
packages/entities/entities-shared/src/components/entity-empty-state/EntityEmptyState.vue
Show resolved
Hide resolved
kaiarrowood
reviewed
Jan 30, 2025
packages/entities/entities-shared/src/components/entity-empty-state/EntityEmptyState.vue
Outdated
Show resolved
Hide resolved
kaiarrowood
reviewed
Jan 31, 2025
packages/entities/entities-shared/src/components/entity-empty-state/EntityEmptyState.vue
Outdated
Show resolved
Hide resolved
kaiarrowood
reviewed
Jan 31, 2025
packages/entities/entities-shared/src/components/entity-empty-state/EntityEmptyState.vue
Show resolved
Hide resolved
kaiarrowood
previously approved these changes
Jan 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
kaiarrowood
dismissed stale reviews from adamdehaven and themself
January 31, 2025 16:17
Issues addressed
kaiarrowood
reviewed
Jan 31, 2025
packages/entities/entities-shared/src/components/entity-empty-state/EntityEmptyState.vue
Outdated
Show resolved
Hide resolved
kaiarrowood
approved these changes
Jan 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
Preview components from this PR in consuming applicationIn consuming application project install preview versions of shared packages generated by this PR:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
JIRA : https://konghq.atlassian.net/browse/KHCP-14905