Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): update slack message #204

Merged
merged 7 commits into from
Jan 16, 2025
Merged

Conversation

pankajmouriyakong
Copy link
Contributor

@pankajmouriyakong pankajmouriyakong commented Jan 8, 2025

Description

Update CI and release workflow to use custom payload to support custom fields such as TriggeredByCommit, Release commit, Event Name, Commit Author.
This also allows us to add any other field required in the future without modifying the local slack shared action.

Why this is needed?

  • The existing Slack shared action only supports few fields and this release and CI slack notifications required some custom fields as mentioned above.

@pankajmouriyakong pankajmouriyakong requested a review from a team as a code owner January 8, 2025 00:31
Copy link

github-actions bot commented Jan 8, 2025

Luacheck Report

1 files  1 suites   0s ⏱️
4 tests 4 ✅ 0 💤 0 ❌
8 runs  8 ✅ 0 💤 0 ❌

Results for commit 59b72e1.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@saisatishkarra saisatishkarra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gtm

@saisatishkarra
Copy link
Collaborator

cc: @dndx for review as well.

@saisatishkarra saisatishkarra changed the title chore(ci,release): update slack message chore(ci): update slack message Jan 13, 2025
Copy link
Collaborator

@saisatishkarra saisatishkarra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gtm

@pankajmouriyakong pankajmouriyakong merged commit 9629f9e into main Jan 16, 2025
15 checks passed
@pankajmouriyakong pankajmouriyakong deleted the update-slack-action-message branch January 16, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants