Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sync) don't return value from timer callback #13973

Closed
wants to merge 1 commit into from

Conversation

chobits
Copy link
Contributor

@chobits chobits commented Dec 3, 2024

Summary

  1. timer's handler should not return value
  2. If timer's handler return value, which triggers luajit modify this function type, then it will trigger a timerng bug: 2024/12/03 17:07:18 [error] 26989#0: *24 [lua] job.lua:290: execute(): [timer-ng] failed to run timer unix_timestamp=1733216838235.000000; counter=11:meta=@./kong/clustering/rpc/socket.lua:67:Lua(): ...l-bin/build/kong-dev/share/lua/5.1/resty/timerng/job.lua:109: bad argument #1 to 'string_len' (string expected, got nil), context: ngx.timer

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

@github-actions github-actions bot added core/clustering cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Dec 3, 2024
@chobits chobits marked this pull request as draft December 3, 2024 10:02
@chobits
Copy link
Contributor Author

chobits commented Dec 4, 2024

closed, we need to fix timerng firstly

@chobits chobits closed this Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/clustering size/XS skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants