Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin key-token. #13955

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add plugin key-token. #13955

wants to merge 1 commit into from

Conversation

BinJu
Copy link

@BinJu BinJu commented Nov 29, 2024

The plugin takes the given key from a configured header name of the incoming traffic, then accesses the configured authentication service for a (JWT) token. The token is cached as the secified TTL and inserted to the request header to access the target service.

TODOs:

  • Add more test coverage for both unit and integration.
  • Understand where to put the doc for this plugin.
  • Need more detailed granular control of accessing authN/authZ server. For example the timeout, return code handling.
  • Need more discussion on the high level design of this plugin. Does the actual use case exist? And how to make it more reliable and flexible.

Summary

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

The plugin takes the given key from a configured header name of the
incoming traffic, then accesses the configured authentication service
for a (JWT) token. The token is cached as the secified TTL and inserted
to the request header to access the target service.

TODOs:
- Add more test coverage for both unit and integration.
- Understand where to put the doc for this plugin.
- Need more detailed granular control of accessing authN/authZ
  server. For example the timeout, return code handling.
- Need more discussion on the high level design of this plugin. Does the
  actual use case exist? And how to make it more reliable and flexible.
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions bot added schema-change-noteworthy cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Nov 29, 2024
@team-eng-enablement team-eng-enablement added the author/community PRs from the open-source community (not Kong Inc) label Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author/community PRs from the open-source community (not Kong Inc) cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee schema-change-noteworthy size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants