Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): initialize route to avoid race (500) #13924

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

StarlightIbuki
Copy link
Contributor

@StarlightIbuki StarlightIbuki commented Nov 26, 2024

Summary

The init router creation could be interrupted and we assume it will always be a non-nil value after the init_worker phase, which may cause 500 to proxy requests.

Let's create an empty router before creating the initial router.

As the issue occurs at this version I omitted the changelog.

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix KAG-5815

@github-actions github-actions bot added core/proxy cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Nov 26, 2024
@StarlightIbuki StarlightIbuki force-pushed the fix/500-init-route branch 2 times, most recently from 103adf1 to 7eeb746 Compare November 26, 2024 07:40
kong/runloop/handler.lua Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/proxy size/S skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants