-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(vault): support array type config reference and multiple nginx subsystem #13855
Open
windmgc
wants to merge
8
commits into
master
Choose a base branch
from
fix/ssl-cert-vault-more-to-be-fixed
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+405
−99
Commits on Nov 20, 2024
-
fix(vault): allow arrays in conf loader to be referenced
### Summary Some properties, like `KONG_SSL_CERT` and `KONG_SSL_CERT_KEY` are arrays and users can specify many. Vaults didn't work in this scenario: For example below didn't work before: ``` CERT_1=$(<cert1.crt) \ KEY_1=$(<key1.key) \ CERT_2=$(<cert2.crt) \ KEY_2=$(<key2.key) \ KONG_SSL_CERT_KEY="{vault://env/key-1},{vault://env/key-2}" \ KONG_SSL_CERT="{vault://env/cert-1},{vault://env/cert-2}" \ kong prepare --vv ``` There were also erroneous warning in logs like because of bad array handling: ``` [warn] 680#0: [kong] vault.lua:1475 error caching secret reference {vault://env/cert-1}: bad value type ``` This fixes those. Signed-off-by: Aapo Talvensaari <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6fae1fb - Browse repository at this point
Copy the full SHA 6fae1fbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 643f9d9 - Browse repository at this point
Copy the full SHA 643f9d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 22d18f3 - Browse repository at this point
Copy the full SHA 22d18f3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6c71ecf - Browse repository at this point
Copy the full SHA 6c71ecfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 843f5e3 - Browse repository at this point
Copy the full SHA 843f5e3View commit details -
Configuration menu - View commit details
-
Copy full SHA for ea9fe4e - Browse repository at this point
Copy the full SHA ea9fe4eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9793830 - Browse repository at this point
Copy the full SHA 9793830View commit details
Commits on Nov 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e302e26 - Browse repository at this point
Copy the full SHA e302e26View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.