Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vault): support array type config reference and multiple nginx subsystem #13855

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Commits on Nov 20, 2024

  1. fix(vault): allow arrays in conf loader to be referenced

    ### Summary
    
    Some properties, like `KONG_SSL_CERT` and `KONG_SSL_CERT_KEY` are
    arrays and users can specify many. Vaults didn't work in this scenario:
    
    For example below didn't work before:
    ```
    CERT_1=$(<cert1.crt) \
    KEY_1=$(<key1.key) \
    CERT_2=$(<cert2.crt) \
    KEY_2=$(<key2.key) \
    KONG_SSL_CERT_KEY="{vault://env/key-1},{vault://env/key-2}" \
    KONG_SSL_CERT="{vault://env/cert-1},{vault://env/cert-2}" \
    kong prepare --vv
    ```
    
    There were also erroneous warning in logs like because of bad array handling:
    
    ```
    [warn] 680#0: [kong] vault.lua:1475 error caching secret reference {vault://env/cert-1}: bad value type
    ```
    
    This fixes those.
    
    Signed-off-by: Aapo Talvensaari <[email protected]>
    bungle authored and windmgc committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    6fae1fb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    643f9d9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    22d18f3 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6c71ecf View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    843f5e3 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    ea9fe4e View commit details
    Browse the repository at this point in the history
  7. test(*): try to fix test

    windmgc committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    9793830 View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2024

  1. Configuration menu
    Copy the full SHA
    e302e26 View commit details
    Browse the repository at this point in the history