-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Replace missing systemd Unit File (2.8) #13778
Conversation
48e38a4
to
e09e3d5
Compare
Issue first raised (to me) in #13464 The EE cherry pick will need the explain_manifest changes expanded for non-CE platforms of that repo. |
Cherry-pick failed for |
Cherry-pick failed for Please cherry-pick the changes locally. git remote add upstream https://github.com/kong/kong-ee
git fetch upstream release/2.8.x
git worktree add -d .worktree/cherry-pick-13778-to-release/2.8.x-to-upstream upstream/release/2.8.x
cd .worktree/cherry-pick-13778-to-release/2.8.x-to-upstream
git checkout -b cherry-pick-13778-to-release/2.8.x-to-upstream
ancref=$(git merge-base 930ca76e3c296fa6816fc9f37e0384b57578ffba e09e3d5cbe9a6e9660060caacb507b71e2298c54)
git cherry-pick -x $ancref..e09e3d5cbe9a6e9660060caacb507b71e2298c54 |
Cherry-pick failed for Please cherry-pick the changes locally. git remote add upstream https://github.com/kong/kong-ee
git fetch upstream release/2.8.x
git worktree add -d .worktree/cherry-pick-13778-to-release/2.8.x-to-upstream upstream/release/2.8.x
cd .worktree/cherry-pick-13778-to-release/2.8.x-to-upstream
git checkout -b cherry-pick-13778-to-release/2.8.x-to-upstream
ancref=$(git merge-base 930ca76e3c296fa6816fc9f37e0384b57578ffba e09e3d5cbe9a6e9660060caacb507b71e2298c54)
git cherry-pick -x $ancref..e09e3d5cbe9a6e9660060caacb507b71e2298c54 |
'git push --set-upstream upstream cherry-pick-13778-to-release/2.8.x-to-upstream' failed with exit code 1 |
Upon further inspection, the systemd unit is named for t in {kong,kong/kong-gateway}:{2.8,3.{8..4}}-ubuntu; do printf '%-50s%s\n' "${t}~" '~' | tr ' ~' '- '; podman run --user=root --platform linux/amd64 -e KONG_DATABASE=off --rm -it $t bash -c 'find / -name "kong*.service"'; done
kong:2.8-ubuntu ----------------------------------
kong:3.8-ubuntu ----------------------------------
/usr/lib/systemd/system/kong.service
kong:3.7-ubuntu ----------------------------------
/usr/lib/systemd/system/kong.service
kong:3.6-ubuntu ----------------------------------
/usr/lib/systemd/system/kong.service
kong:3.5-ubuntu ----------------------------------
/usr/lib/systemd/system/kong.service
kong:3.4-ubuntu ----------------------------------
/usr/lib/systemd/system/kong.service
kong/kong-gateway:2.8-ubuntu ---------------------
/usr/lib/systemd/system/kong-enterprise-edition.service
kong/kong-gateway:3.8-ubuntu ---------------------
/usr/lib/systemd/system/kong-enterprise-edition.service
kong/kong-gateway:3.7-ubuntu ---------------------
/usr/lib/systemd/system/kong-enterprise-edition.service
kong/kong-gateway:3.6-ubuntu ---------------------
/usr/lib/systemd/system/kong-enterprise-edition.service
kong/kong-gateway:3.5-ubuntu ---------------------
/usr/lib/systemd/system/kong-enterprise-edition.service
kong/kong-gateway:3.4-ubuntu ---------------------
/usr/lib/systemd/system/kong-enterprise-edition.service |
Is there a 2.8,x build expected soon to release this change ? |
Summary
This PR fixes an issue where the systemd unit file,
kong.service
, had gone missing from packages produced from the 2.8 branch(es).Checklist
changelog/unreleased/kong
orskip-changelog
label added on PR if changelog is unnecessary. README.mdIssue reference
Fix #KAG-5648