-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): bump ngx_wasm_module to ae7b61150de7c14eb901307daed403b67f29e962 #13222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
cherry-pick kong-ee
schedule this PR for cherry-picking to kong/kong-ee
core/wasm
Everything relevant to [proxy-]wasm
labels
Jun 17, 2024
…7f29e962 Note: The `start()` function of `resty.wasmx.proxy_wasm` was removed in the dependency, so it's been patched out here. This function is no longer required to run wasm filters from Lua land. Changes since 91d447ffd0e9bb08f11cc69d1aa9128ec36b4526: * ae7b611 - style(*) catch switch/case indentation * 6622c43 - chore(util) apply a fix to Test::Nginx as a patch * 223a346 - chore(ci) move CodeQL analysis to its own recurring workflow * 3dbf52a - fix(proxy-wasm) resume content phase after request_body read EAGAIN * 2f56de3 - refactor(lua-bridge) remove entry thread sleep timer handling * ef6ff76 - fix(proxy-wasm) cancel dispatches when immediately producing a response * b26106c - feat(proxy-wasm) dispatch errors do not interrupt filter chains * e96471f - refactor(lua-bridge) rewrite for full yielding support * b7e1b75 - chore(lib) add 'NGX_BUILD_SSL_STATIC' to build options hash * 277fac6 - chore(deps) bump Nginx to 1.27.0 * f74c6cb - chore(deps) bump OpenSSL to 3.3.1 * b19d405 - chore(release) fix MacOS releases * 8799cc9 - fix(lib) prevent a segfault loading an empty .wat module with V8 * 8ac549f - chore(ci) upload executable and coredumps on failure
flrgh
force-pushed
the
chore/deps-bump-ngx-wasm-module
branch
from
June 17, 2024 19:32
abce61f
to
0aac1f8
Compare
flrgh
approved these changes
Jun 17, 2024
team-eng-enablement
added
the
author/community
PRs from the open-source community (not Kong Inc)
label
Jun 17, 2024
locao
reviewed
Jun 17, 2024
locao
reviewed
Jun 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than my minor comment in the changelog, this change LGTM. But there are (what seems) unrelated tests failing.
Let's see if it was a gha hiccup.
locao
approved these changes
Jun 17, 2024
brentos
approved these changes
Jun 17, 2024
Co-authored-by: Vinicius Mignot <[email protected]>
github-actions
bot
added
the
incomplete-cherry-pick
A cherry-pick was incomplete and needs manual intervention
label
Jun 17, 2024
kikito
removed
the
incomplete-cherry-pick
A cherry-pick was incomplete and needs manual intervention
label
Jun 18, 2024
locao
added a commit
that referenced
this pull request
Jun 21, 2024
…7f29e962 (#13222) * chore(deps): bump ngx_wasm_module to ae7b61150de7c14eb901307daed403b67f29e962 Note: The `start()` function of `resty.wasmx.proxy_wasm` was removed in the dependency, so it's been patched out here. This function is no longer required to run wasm filters from Lua land. Changes since 91d447ffd0e9bb08f11cc69d1aa9128ec36b4526: * ae7b611 - style(*) catch switch/case indentation * 6622c43 - chore(util) apply a fix to Test::Nginx as a patch * 223a346 - chore(ci) move CodeQL analysis to its own recurring workflow * 3dbf52a - fix(proxy-wasm) resume content phase after request_body read EAGAIN * 2f56de3 - refactor(lua-bridge) remove entry thread sleep timer handling * ef6ff76 - fix(proxy-wasm) cancel dispatches when immediately producing a response * b26106c - feat(proxy-wasm) dispatch errors do not interrupt filter chains * e96471f - refactor(lua-bridge) rewrite for full yielding support * b7e1b75 - chore(lib) add 'NGX_BUILD_SSL_STATIC' to build options hash * 277fac6 - chore(deps) bump Nginx to 1.27.0 * f74c6cb - chore(deps) bump OpenSSL to 3.3.1 * b19d405 - chore(release) fix MacOS releases * 8799cc9 - fix(lib) prevent a segfault loading an empty .wat module with V8 * 8ac549f - chore(ci) upload executable and coredumps on failure Co-authored-by: Vinicius Mignot <[email protected]> --------- Co-authored-by: team-gateway-bot <[email protected]> Co-authored-by: Michael Martin <[email protected]> Co-authored-by: Vinicius Mignot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author/community
PRs from the open-source community (not Kong Inc)
cherry-pick kong-ee
schedule this PR for cherry-picking to kong/kong-ee
core/proxy
core/wasm
Everything relevant to [proxy-]wasm
size/S
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
91d447f...ae7b611
Compare on GitHub
ae7b611
- style(*) catch switch/case indentation6622c43
- chore(util) apply a fix to Test::Nginx as a patch223a346
- chore(ci) move CodeQL analysis to its own recurring workflow3dbf52a
- fix(proxy-wasm) resume content phase after request_body read EAGAIN2f56de3
- refactor(lua-bridge) remove entry thread sleep timer handlingef6ff76
- fix(proxy-wasm) cancel dispatches when immediately producing a responseb26106c
- feat(proxy-wasm) dispatch errors do not interrupt filter chainse96471f
- refactor(lua-bridge) rewrite for full yielding supportb7e1b75
- chore(lib) add 'NGX_BUILD_SSL_STATIC' to build options hash277fac6
- chore(deps) bump Nginx to 1.27.0f74c6cb
- chore(deps) bump OpenSSL to 3.3.1b19d405
- chore(release) fix MacOS releases8799cc9
- fix(lib) prevent a segfault loading an empty .wat module with V88ac549f
- chore(ci) upload executable and coredumps on failureTODO
.requirements
as neededsee also
KAG-4671