feat(wasm): add support for wasmtime cache #12930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core/cli
core/templates
core/configuration
cherry-pick kong-ee
flrgh
force-pushed
the
feat/wasm-module-cache
branch
2 times, most recently
from
35d459c to
945dec3
Compare
flrgh
force-pushed
the
feat/wasm-module-cache
branch
2 times, most recently
from
7a5c92c to
4c9bf05
Compare
flrgh
force-pushed
the
feat/wasm-module-cache
branch
3 times, most recently
from
b431ca9 to
2f034f9
Compare
|
Is it possible to add a test for restarting kong with the cache enabled? Otherwise LGTM |
flrgh
force-pushed
the
feat/wasm-module-cache
branch
from
2f034f9 to
765baba
Compare
brentos
approved these changes
May 23, 2024
Yeah mainly i wanted to make sure nothing broke by introducing the cache, that things work with existing cache files on restart. Thanks! |
This adds support for Wasmtime's module caching. See also: * Kong/ngx_wasm_module#540 * https://github.com/Kong/ngx_wasm_module/blob/b19d405403ca6765c548e571010aea3af1accaea/docs/DIRECTIVES.md?plain=1#L136-L149 * https://docs.wasmtime.dev/cli-cache.html
flrgh
force-pushed
the
feat/wasm-module-cache
branch
from
765baba to
296ccb5
Compare
|
Cherry-pick failed for Please cherry-pick the changes locally. git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-12930-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-12930-to-master-to-upstream
git checkout -b cherry-pick-12930-to-master-to-upstream
ancref=$(git merge-base 4052fbbfee77be52bcd5c876719a84bcbc8ba337 296ccb531a142cc5dafc428e24af60646de84372)
git cherry-pick -x $ancref..296ccb531a142cc5dafc428e24af60646de84372 |
github-actions
bot
added
the
incomplete-cherry-pick
Manually cherry-picked: https://github.com/Kong/kong-ee/pull/9389 |
flrgh
removed
the
incomplete-cherry-pick
locao
pushed a commit
that referenced
this pull request
Jun 21, 2024
* feat(wasm): add support for wasmtime cache This adds support for Wasmtime's module caching. See also: * Kong/ngx_wasm_module#540 * https://github.com/Kong/ngx_wasm_module/blob/b19d405403ca6765c548e571010aea3af1accaea/docs/DIRECTIVES.md?plain=1#L136-L149 * https://docs.wasmtime.dev/cli-cache.html * tests(wasm): add start/restart test for wasmtime cache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loading .wasm module binaries involves a compilation step before they can be executed, which can slow Kong's startup time. This enable's Wasmtime's builtin cache, such that subsequent start/stop/restart cycles can be faster with a warm cache.
See also:
KAG-4372