Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(pdk): use resty.core.utils.str_replace_char instead of gsub #11823

Merged
merged 3 commits into from
Oct 25, 2023
Merged

refactor(pdk): use resty.core.utils.str_replace_char instead of gsub #11823

merged 3 commits into from
Oct 25, 2023

Conversation

chronolaw
Copy link
Contributor

@chronolaw chronolaw commented Oct 24, 2023 •
edited
Loading

Summary

It is a sister PR of #11721, optimize the code of pdk.

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Full changelog

  • [Implement ...]

Issue reference

Fix #[issue number]

bungle
bungle requested changes Oct 24, 2023
View reviewed changes
Copy link
Member

@bungle bungle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just small style change

kong/pdk/vault.lua Outdated Show resolved Hide resolved
@windmgc windmgc merged commit d286856 into master Oct 25, 2023
23 checks passed
@windmgc windmgc deleted the refactor/pdk_use_str_replace_char branch October 25, 2023 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzssangglass tzssangglass tzssangglass approved these changes

@bungle bungle bungle approved these changes

@chobits chobits chobits approved these changes

Assignees

@chronolaw chronolaw

Labels
core/pdk size/S skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chronolaw @chobits @bungle @tzssangglass @windmgc