Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(*): isolate test-only deps and housekeeping #68

Merged
merged 2 commits into from
Aug 4, 2023
Merged

chore(*): isolate test-only deps and housekeeping #68

merged 2 commits into from
Aug 4, 2023

Conversation

sumimakito
Copy link
Member

@sumimakito sumimakito commented Aug 3, 2023 •
edited
Loading

Summary

  • Added a DEVELOPMENT.md for end-to-end testing
  • Moved E2E test-only dependencies into a separate package.json in tests/playwright:
    • @playwright/test
    • bmp-js
  • Mapped root-level E2E test commands to ones in tests/playwright:
    Root-level command Equivalent to command in tests/playwright
    yarn install:e2e yarn install
    yarn test:e2e yarn run test
    yarn playwright yarn run playwright
  • Replaced scattered lodash.* dependencies with lodash-es which supports tree-shaking
  • Made files under tests/playwright modules (removed all requires, __dirnames, etc.)
  • Cleaned up tsconfig.json in tests/playwright

Issue reference

KAG-2137

@sumimakito sumimakito force-pushed the chore/ci-test-only-deps branch 2 times, most recently from f09fdd9 to edc9665 Compare August 4, 2023 03:33
@sumimakito sumimakito marked this pull request as ready for review August 4, 2023 06:22
@sumimakito sumimakito requested review from mheap and a team August 4, 2023 06:23
@sumimakito sumimakito self-assigned this Aug 4, 2023
Leopoldthecoder
Leopoldthecoder approved these changes Aug 4, 2023
View reviewed changes
Copy link
Member

@Leopoldthecoder Leopoldthecoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nekolab
nekolab approved these changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@nekolab nekolab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sumimakito sumimakito merged commit 36f841c into main Aug 4, 2023
@sumimakito sumimakito deleted the chore/ci-test-only-deps branch August 4, 2023 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leopoldthecoder Leopoldthecoder Leopoldthecoder approved these changes

@nekolab nekolab nekolab approved these changes

@mheap mheap Awaiting requested review from mheap

Assignees

@sumimakito sumimakito

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sumimakito @nekolab @Leopoldthecoder