Skip to content

Commit

Permalink
minor symfony#2138 [Map] Adjust changelogs and fix render_map depre…
Browse files Browse the repository at this point in the history
…cated version (Kocal)

This PR was merged into the 2.x branch.

Discussion
----------

[Map] Adjust changelogs and fix `render_map` deprecated version

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Issues        | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License       | MIT

<!--
Replace this notice by a description of your feature/bugfix.
This will help reviewers and should be a good start for the documentation.

Additionally (see https://symfony.com/releases):
 - Always add tests and ensure they pass.
 - For new features, provide some code snippets to help understand usage.
 - Features and deprecations must be submitted against branch main.
 - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry
 - Never break backward compatibility (see https://symfony.com/bc).
-->

While working on symfony#2070, I noticed Map's changelogs were still containing `Unreleased` instead of the version number.
I've also changed the version where `render_map` twig function have been deprecated, to match the reality (the 2.20 will be the next release!).

Commits
-------

06b248a [Map] Adjust changelogs and fix `render_map` deprecated version
  • Loading branch information
Kocal committed Sep 9, 2024
2 parents 5c17b26 + 06b248a commit e84a96e
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion src/Map/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# CHANGELOG

## Unreleased
## 2.20

- Rename `render_map` Twig function `ux_map`
- Deprecate `render_map` Twig function
Expand Down
2 changes: 1 addition & 1 deletion src/Map/src/Bridge/Google/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# CHANGELOG

## Unreleased
## 2.19

- Bridge added
2 changes: 1 addition & 1 deletion src/Map/src/Bridge/Leaflet/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# CHANGELOG

## Unreleased
## 2.19

- Bridge added
2 changes: 1 addition & 1 deletion src/Map/src/Twig/MapExtension.php
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ public function getFunctions(): array
return [
new TwigFunction('render_map', [Renderers::class, 'renderMap'], [
'is_safe' => ['html'],
'deprecated' => '2.21',
'deprecated' => '2.20',
'deprecating_package' => 'symfony/ux-map',
'alternative' => 'ux_map',
]),
Expand Down

0 comments on commit e84a96e

Please sign in to comment.