Merge pull request #620 from nicolasmure/fix/do-not-create-local-dire…

…ctory-automatically [1.0] Do not automatically create the base directory for Local adapter
KnpLabs · Jul 1, 2019 · a93e739 · a93e739
2 parents a18a6f7 + b7a7bea
commit a93e739
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/spec/Gaufrette/Adapter/LocalSpec.php b/spec/Gaufrette/Adapter/LocalSpec.php
@@ -32,6 +32,13 @@ function it_is_a_mime_type_provider()
         $this->shouldHaveType('Gaufrette\Adapter\MimeTypeProvider');
     }
 
+    function it_throws_when_the_base_directory_does_not_exist()
+    {
+        $this->beConstructedWith('/do-no-exists');
+
+        $this->shouldThrow(StorageFailure::class)->duringInstantiation();
+    }
+
     function it_gets_the_file_mime_type()
     {
         $this->mimeType('filename')->shouldReturn('text/plain');

diff --git a/src/Gaufrette/Adapter/Local.php b/src/Gaufrette/Adapter/Local.php
@@ -18,7 +18,6 @@
 class Local implements Adapter, StreamFactory, ChecksumCalculator, SizeCalculator, MimeTypeProvider
 {
     protected $directory;
-    private $create;
     private $mode;
 
     /**
@@ -33,6 +32,12 @@ public function __construct($directory, $mode = 0777)
         if (is_link($this->directory)) {
             $this->directory = realpath($this->directory);
         }
+
+        if (!is_dir($this->directory)) {
+            throw new StorageFailure(
+                sprintf('Directory "%s" does not exist.', $directory)
+            );
+        }
     }
 
     /**