Adjust default/generic config for printrboards #6755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ot simple, Simple Metal 1403, Simple Metal 2016 V2, Play, etc.) had the Y endstop on Y max, and the Y stepper direction reversed. Furthermore, the build volums were more commonly 150mm.
|
Thank you for submitting a PR, please be aware that you need to sign off to accept the developer certificate of origin, please see point 3 in https://github.com/Klipper3d/klipper/blob/master/docs/CONTRIBUTING.md#what-to-expect-in-a-review Thanks |
… simple, Simple Metal 1403, Simple Metal 2016 V2, Play, etc.) had the Y endstop on Y max, and the Y stepper direction reversed. Furthermore, the build volums were more commonly 150mm. Signed-off-by: Charles Lee Scoville.
|
Sorry for the delay, have a lot going on. I have tried to do as you asked, but github fights me. Hopefully I have correct now? If nothing else, I can sign off in the comments here. |
|
Thank you for the update, but as the docs state we need a name and an email address to fully sign off. Apart from that I cant see an issue, as the change reflects the most common use of these boards. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most Printrbot 3D printers that shipped with the printrboard (Printrbot simple, Simple Metal 1403, Simple Metal 2016 V2, Play, etc.) had the Y endstop on Y max, and the Y stepper direction reversed. Furthermore, the build volumes were more commonly 150mm.
I have edited the relevant config file to reflect this. I have also tested the changes on a Printrbot Simple Metal 1403, and it works as expected.
Edit:
Signed-off-by: Charles Lee Scoville