Add sort by date and reverse order sorting to vsdlist lcd menu item. #6751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for submitting a PR, please be aware that you need to sign off to accept the developer certificate of origin, please see point 3 in https://github.com/Klipper3d/klipper/blob/master/docs/CONTRIBUTING.md#what-to-expect-in-a-review Thanks |
galagithub
force-pushed
the
feature/vsdlist_sorters
branch
from
f09f6a3 to
7794d33
Compare
reworked the commit, hope it is ok now. thanks. |
galagithub
force-pushed
the
feature/vsdlist_sorters
branch
2 times, most recently
from
7794d33 to
4e15a4f
Compare
This adds two config directives for sorting vsdlist (sd card file list) on a LCD connected to the printer (dumb character display). Add "sort_by_date: True" to a vsdlist menu config to have the files sorted by date chronologically. If not present or "False" then files will be sorted alphabetically just as before. Add "sort_reverse: True" to a vsdlist menu config to have the files sorted in reverse order (descending). If not present or "False" then the files will be sorted in ascending order just as before. By setting both "sort_by_date" and "sort_reverse" to "True" files will be sorted in reverse chronological order (newest first). Please note the file timestamp (date) is taken from the filesystem and some filesystems may have broken timestamps on subsequent writes. Signed-off-by: Dragos Galalae <gala 'underline' dragos 'at' yahoo 'dot' com>
galagithub
force-pushed
the
feature/vsdlist_sorters
branch
from
4e15a4f to
c3a5e95
Compare
|
any updates on this ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds two config directives for sorting vsdlist (sd card file list) on a LCD connected to the printer (dumb character display).
I've seen this asked around the web, got it working on my klipper installation.
Now you can add "sort_reverse" and "sort_by_date" to a menu config and have the files sorted by date or alphabetically, also in reverse.
Example config: