Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts: update greenlet to 3.0.3 #6525

Merged
merged 1 commit into from
Mar 19, 2024
Merged

scripts: update greenlet to 3.0.3 #6525

merged 1 commit into from
Mar 19, 2024

Conversation

mkuf
Copy link
Contributor

@mkuf mkuf commented Mar 10, 2024

Installation of requirements fails starting at python 3.12.
This is due to greenlet requirement of 2.0.2, which is not compatible w/ python 3.12.

This PR updates greenlet to the latest release 3.0.3

@mkuf
Copy link
Contributor Author

mkuf commented Mar 10, 2024

About the failed checks:

It does seem that greenlet 3.0.3 is not available for python2.
Merging this would essentially make the python requirements incompatible with python2.

If you want to go forward with this, I can try to provide a patch to remove the python2 checks from the review workflow and update the workflow to run with a more recent python3.12.
This could either be done in the course of this PR or in a separate PR.

Please provide feedback on how to proceed.

-Markus

@KevinOConnor
Copy link
Collaborator

I have noticed this conflict as well. Alas, I don't have any good suggestions on how to best proceed.

-Kevin

@mkuf
Copy link
Contributor Author

mkuf commented Mar 15, 2024

I think I have found a less intrusive solution, which maintains compatibility with previous python versions < 3.12 as well as versions >= 3.12.

pip supports defining requirement specifiers, which allow to skip packages if certain conditions are not met.
This way, when installing requirements on python < 3.12, greenlet 2.0.2 is used and with python >= 3.12, greenlet 3.0.3 is installed.

This also fixed the issue with the failed check and requirements are still compatible with python2, so the decision if support for python2 should be dropped can be revisited at a later date.

-Markus

@KevinOConnor
Copy link
Collaborator

Ah, thanks. That seems like a good plan. I'll give a few days to see if others have comments, but otherwise look to commit.

-Kevin

@turk-fx
Copy link

turk-fx commented Mar 18, 2024

About the failed checks:

It does seem that greenlet 3.0.3 is not available for python2. Merging this would essentially make the python requirements incompatible with python2.

If you want to go forward with this, I can try to provide a patch to remove the python2 checks from the review workflow and update the workflow to run with a more recent python3.12. This could either be done in the course of this PR or in a separate PR.

Please provide feedback on how to proceed.

-Markus

I can try whatever you want me try. Just let me know what to do.

@turk-fx
Copy link

turk-fx commented Mar 18, 2024

Just a quick question. I am new to these type of stuff. So, I should wait till a new release or this plan is committed to a new package?

@KevinOConnor KevinOConnor merged commit 78a15b6 into Klipper3d:master Mar 19, 2024
1 check passed
@KevinOConnor
Copy link
Collaborator

Thanks.

-Kevin

@Piraty
Copy link

Piraty commented Jan 7, 2025

greenlet==3.0.3 ; python_version >= '3.12'
this fails with python3.13 , you need to relax the constraint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants