-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scripts: update greenlet to 3.0.3 #6525
Conversation
About the failed checks: It does seem that greenlet 3.0.3 is not available for python2. If you want to go forward with this, I can try to provide a patch to remove the python2 checks from the review workflow and update the workflow to run with a more recent python3.12. Please provide feedback on how to proceed. -Markus |
I have noticed this conflict as well. Alas, I don't have any good suggestions on how to best proceed. -Kevin |
Signed-off-by: Markus Küffner <[email protected]>
I think I have found a less intrusive solution, which maintains compatibility with previous python versions pip supports defining requirement specifiers, which allow to skip packages if certain conditions are not met. This also fixed the issue with the failed check and requirements are still compatible with python2, so the decision if support for python2 should be dropped can be revisited at a later date. -Markus |
Ah, thanks. That seems like a good plan. I'll give a few days to see if others have comments, but otherwise look to commit. -Kevin |
I can try whatever you want me try. Just let me know what to do. |
Just a quick question. I am new to these type of stuff. So, I should wait till a new release or this plan is committed to a new package? |
Thanks. -Kevin |
|
Installation of requirements fails starting at python 3.12.
This is due to greenlet requirement of 2.0.2, which is not compatible w/ python 3.12.
This PR updates greenlet to the latest release 3.0.3