Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(klippy, toolhead): add S<seconds> param to G4 command #6499

Closed

Conversation

slaesh
Copy link

@slaesh slaesh commented Feb 19, 2024

this adds the ability to pass an S<seconds> parameter to the G4 dwell command.
its even possible to combine the existing P<milliseconds> with the newly added S param.

took me a while to realize that klippers G4 interpreter only used the P param.. :))

To-Do:

  • ask/clarify: logging format, do we want to prefix it. or dont log at all??
  • ask/clarify: if not dwelling at all for the None case is okay?
  • adjust docs

Signed-off-by: Sascha Ehlers [email protected]

@slaesh slaesh marked this pull request as ready for review February 19, 2024 12:27
@pedrolamas
Copy link
Contributor

My understanding is that Klipper is not trying to replicate the full Marlin gcode support, hence why this is not implemented.

For now, you can easily fix this issue by overriding G4 with a custom macro:

[gcode_macro G4]
rename_existing: G4.1
gcode:
  G4.1 P{ params.P | default((params.S | default(0) | int) * 1000) }

The above will allow you to use either P or S params.

@slaesh
Copy link
Author

slaesh commented Feb 21, 2024

thanks for the hint. before doing that, I will keep adding some zeros here and there ;)

otherwise shared config's wont work anymore on another klipper instance :)

in my feeling this doesnt hurt, but sure it does not add so much value either. since no one requested this earlier, at least cant find any related issue.. I will close this one then =)

@slaesh slaesh closed this Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants