Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts: Added shaper tuning parameters to calibrate_shaper script #6487

Merged
merged 1 commit into from
Feb 17, 2024

Conversation

dmbutyugin
Copy link
Collaborator

The added parameters include square_corner_velocity, shaper frequencies to optimize, input shapers to test, input shaper damping ratio and damping ratios to test. All these options can be useful for fine-tuning the input shapers when the default suggestions generated by the tuning script are not optimal.

Also the SHAPER_CALIBRATE command was modified to pass some of these parameters to the shaper tuning routine. Specifically, square corner velocity and the maximum tested frequency are used to adjust shaper tuning and maximum acceleration recommendations.

I think the possibility to specify the square_corner_velocity is most useful. Some people change it against the recommendations, but may use the same maximum acceleration recommendations from the script without realizing that they should be adjusted. This change allows them to get better estimates for maximum accelerations and potentially make better and more informed decisions about raising square_corner_velocity parameter. Then the possibility to tune only a subset of shapers and specific frequencies may be useful for advanced users who wanted to do fine-tuning of the shapers, but lacked the tools to do so.

The added parameters include square_corner_velocity, shaper frequencies
to optimize, input shapers to test, input shaper damping ratio and
damping ratios to test. All these options can be useful for fine-tuning
the input shapers when the default suggestions generated by the tuning
script are not optimal.

Also the `SHAPER_CALIBRATE` command was modified to pass some of these
parameters to the shaper tuning routine. Specifically, square corner
velocity and the maximum tested frequency are used to adjust shaper
tuning and maximum acceleration recommendations.

Signed-off-by: Dmitry Butyugin <[email protected]>
@KevinOConnor
Copy link
Collaborator

KevinOConnor commented Feb 10, 2024

Thanks. Let me know when you'd like me to merge this.

Cheers,
-Kevin

EDIT: Or more specifically, if there are no further comments on this in the next few days then I'll plan to merge this.

@KevinOConnor KevinOConnor merged commit 72b301a into Klipper3d:master Feb 17, 2024
1 check passed
@KevinOConnor
Copy link
Collaborator

Thanks.

-Kevin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants