scripts: Added shaper tuning parameters to calibrate_shaper script #6487
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The added parameters include square_corner_velocity, shaper frequencies to optimize, input shapers to test, input shaper damping ratio and damping ratios to test. All these options can be useful for fine-tuning the input shapers when the default suggestions generated by the tuning script are not optimal.
Also the
SHAPER_CALIBRATE
command was modified to pass some of these parameters to the shaper tuning routine. Specifically, square corner velocity and the maximum tested frequency are used to adjust shaper tuning and maximum acceleration recommendations.I think the possibility to specify the
square_corner_velocity
is most useful. Some people change it against the recommendations, but may use the same maximum acceleration recommendations from the script without realizing that they should be adjusted. This change allows them to get better estimates for maximum accelerations and potentially make better and more informed decisions about raisingsquare_corner_velocity
parameter. Then the possibility to tune only a subset of shapers and specific frequencies may be useful for advanced users who wanted to do fine-tuning of the shapers, but lacked the tools to do so.