-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bed_mesh: support for Z in BED_MESH_OFFSET #6485
bed_mesh: support for Z in BED_MESH_OFFSET #6485
Conversation
Thanks. Let me know when you'd like me to merge. Separately, have you considered naming the parameter something other than -Kevin |
That's a good idea, I just made the changes. I'll squash when its ready to go. I hope to get some feedback from users with multiple tools, they can chime in on the name of the parameter as well if they would like. |
Just to chime in as a user with a multi-toolhead printer - I was mistaken in my understanding of how That being said, I think this is a useful change and I agree that Completely off topic from the purpose of this PR - I wish there was a way to compensate for Z position differences in a toolhead and still allow global baby-stepping/live Z adjustment. Currently using |
When a ZFADE value is passed to BED_MESH_OFFSET it is used to adjust how fade is applied. This resolves issues with fade when SET_GCODE_OFFSET is used during a tool change. Signed-off-by: Eric Callahan <[email protected]>
Add the ZFADE parameter to the documentation. Signed-off-by: Eric Callahan <[email protected]>
7f22f87
to
3fc47f1
Compare
Thanks for the feedback fiferboy. I suspect that a good test will require a setup where there is substantial difference in nozzle height between tools. This addition was requested, so presumably it was causing an issue for a number of users out there. The change is relatively simple and I'm confident it will work as intended, so if there is no other feedback I'm ok with merging now. |
Thanks. -Kevin |
This adds a "Z" parameter to
BED_MESH_OFFSET
that is used to account for changes ingcode offset
on the Z axis when calculating fade. Without this, changing a tool that is offset on Z will cause jumps in the fade calculation. This likely makes fade unusable for multi-tool printers.This addition does not add any additional adjustment on the z-axis, so it cannot be used to replace
SET_GCODE_OFFSET
, and instead must be used to complement it. LikeX
andY
, theZ
offset should be relative to the primary extruder. If a secondary extruder's nozzle is higher than the primary extruder by .2mm, thenBED_MESH_OFFSET Z=.2
is the correct setting. Presumably this would come afterSET_GCODE_OFFSET Z=-.2
. I believe this is consistent across all axes, but if it isn't I am open to changing the behavior.This will need to be tested by some individuals with multiple tools, as I am unable to do so.