Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skew_Correction.md typo #6478

Closed
wants to merge 1 commit into from
Closed

Skew_Correction.md typo #6478

wants to merge 1 commit into from

Conversation

streetgt
Copy link

Fix typo

@JamesH1978
Copy link
Collaborator

Thank you for submitting a PR, pleas refer to point 3 in "What to expect in a review" in https://github.com/Klipper3d/klipper/blob/master/docs/CONTRIBUTING.md and provide a signed off by line.

Thanks
James

thijstriemstra
thijstriemstra approved these changes Feb 4, 2024
View reviewed changes
Copy link
Contributor

@thijstriemstra thijstriemstra left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Thank you for submitting a PR, pleas refer to point 3 in "What to expect in a review

good point

@streetgt
Copy link
Author

streetgt commented Feb 4, 2024 •
edited
Loading

thanks!

Thank you for submitting a PR, pleas refer to point 3 in "What to expect in a review

good point

The PR is self explanatory and is no harmfull to the codebase, I don't see any point of justification when it's just a typo....

@streetgt streetgt changed the title Update Skew_Correction.md Skew_Correction.md typo Feb 4, 2024
@thijstriemstra
Copy link
Contributor

provide a signed off by line.

is what I meant

@streetgt
Copy link
Author

streetgt commented Feb 4, 2024

Do whatever you guys want, not going to waste time on this and any other Klipper contribution, jesus.

@KevinOConnor
Copy link
Collaborator

I made the corresponding change to the docs (commit 9a940ff).

-Kevin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thijstriemstra thijstriemstra thijstriemstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@streetgt @JamesH1978 @thijstriemstra @KevinOConnor