bed_mesh: behavior fixes #6473
Merged
bed_mesh: behavior fixes #6473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not generate points for the zero_reference_position or faulty_regions when manual probing is requested. Signed-off-by: Eric Callahan <[email protected]>
Adaptive meshing avoids saving the mesh after calibration to prevent users from inadvertently overwriting an existing profile with an adaptive mesh. This introduced a change in behavior of how get_status() reports the profile_name, as it can now be an empty string when a mesh is active. This patch assigns adaptive meshes a name with a unique postfix. In addition, it moves profile name tracking from the profile manager to the ZMesh class. Signed-off-by: Eric Callahan <[email protected]>
|
Thanks. I don't think we should wait for #6459 - I'll rebase that PR as needed. Let me know when you'd like me to commit this PR. -Kevin |
|
Wow awesome work @Arksine with the quick fix! |
|
Sounds good. I have tested the changes here and everything works as expected. You can commit when ready. |
|
Thanks. -Kevin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes two minor fixes to the behavior of bed_mesh.
Avoid probing additional points for the
zero_reference_positionandfaulty_regionswhen the user chooses the "manual" method. Those options aren't useful when probing manually.Fix a reporting regression introduced by the adaptive mesh change. Since we avoid saving the mesh, the value reported in the
profile_namefield will be whatever was previously stored inProfileManger.current_profile. This is often an empty string, which is leading some frontends to believe that no mesh is loaded. This patch moves profile name tracking to the ZMesh class and generates a placeholder name for adaptive meshes.Kevin, this is likely going to cause a merge conflict with #6459, so if you would like we can hold this PR until its merged and I will resolve the conflicts.