same70: Add CAN #6366
Merged
same70: Add CAN #6366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wulfsta
force-pushed
the
same70-canbus
branch
2 times, most recently
from
14c5f73 to
56f0d30
Compare
src/atsam/main.c
Outdated
Comment on lines
69
to
70
| #if CONFIG_MACH_SAME70 | ||
| if (id == MCAN0_CLOCK_ID || id == MCAN1_CLOCK_ID) | ||
| return FREQ_CAN; | ||
| #endif |
There was a problem hiding this comment.
As before, it would be preferable to use a regular if instead of an ifdef.
There was a problem hiding this comment.
This isn't feasible here, unless we also define the clock ids for other chips, which would be a bit silly. Going to keep this one.
Wulfsta
force-pushed
the
same70-canbus
branch
5 times, most recently
from
fec3a00 to
49d6a91
Compare
Signed-off-by: Luke Vuksta <[email protected]>
Wulfsta
force-pushed
the
same70-canbus
branch
from
49d6a91 to
c9b36e3
Compare
|
Thanks. -Kevin |
4rianton
pushed a commit
to 4rianton/klipper
that referenced
this pull request
Oct 19, 2023
Signed-off-by: Luke Vuksta <[email protected]>
rogerlz
referenced
this pull request
in KalicoCrew/kalico
Dec 19, 2023
Signed-off-by: Luke Vuksta <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add CAN to same70. Thanks to @eamaclean for the help.
Depends on #6365.