Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add weighing sensor HX710/HX711/HX712 #6350

Closed
wants to merge 2 commits into from

Conversation

GuoGeTiertime
Copy link

@GuoGeTiertime GuoGeTiertime commented Sep 22, 2023

I implemented support for weighing sensor HX710/HX711/HX712
and tested on HX711.

The HX71X class is very simple and the function is periodically
to read the measurement data from HX711. This is a base class,
and other modules can query the measurements to complete bed mesh
, XYZ home probe or record filament usage.

the Configuration exmaple:
[hx71x HX711]
hx71x_mcu: mcu
hx71x_sck_pin: PD6
hx71x_dout_pin: PD7
hx71x_report_time: 0.5
hx71x_scale: -0.002

Signed-off-by: GuoGe [email protected]

@Sineos
Copy link
Collaborator

Sineos commented Sep 22, 2023

Thank you for submitting a PR, please could you refer to point 3 in the "what to expect" section in master/docs/CONTRIBUTING.md and add a signed-off-by line.

Also, you might want to cross-check and align with:

@github-actions
Copy link

github-actions bot commented Oct 9, 2023

Thank you for your contribution to Klipper. Unfortunately, a reviewer has not assigned themselves to this GitHub Pull Request. All Pull Requests are reviewed before merging, and a reviewer will need to volunteer. Further information is available at: https://www.klipper3d.org/CONTRIBUTING.html

There are some steps that you can take now:

  1. Perform a self-review of your Pull Request by following the steps at: https://www.klipper3d.org/CONTRIBUTING.html#what-to-expect-in-a-review
    If you have completed a self-review, be sure to state the results of that self-review explicitly in the Pull Request comments. A reviewer is more likely to participate if the bulk of a review has already been completed.
  2. Consider opening a topic on the Klipper Discourse server to discuss this work. The Discourse server is a good place to discuss development ideas and to engage users interested in testing. Reviewers are more likely to prioritize Pull Requests with an active community of users.
  3. Consider helping out reviewers by reviewing other Klipper Pull Requests. Taking the time to perform a careful and detailed review of others work is appreciated. Regular contributors are more likely to prioritize the contributions of other regular contributors.

Unfortunately, if a reviewer does not assign themselves to this GitHub Pull Request then it will be automatically closed. If this happens, then it is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available.

Best regards,
~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.

@github-actions
Copy link

Unfortunately a reviewer has not assigned themselves to this GitHub Pull Request and it is therefore being closed. It is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available.

Best regards,
~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.

@github-actions github-actions bot closed this Oct 24, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants