Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uc1701: x_offset and columns values added for uc1701 displays #6323

Closed
wants to merge 1 commit into from

Conversation

VragVideo
Copy link

Changing x_offset and columns in the printer.cfg allows to fix artifacts like shown on image. x_offset parameter shifts picture forward and columns parameter set to 132 clear point at end of line.
image

@github-actions
Copy link

Thank you for your contribution to Klipper. Unfortunately, a reviewer has not assigned themselves to this GitHub Pull Request. All Pull Requests are reviewed before merging, and a reviewer will need to volunteer. Further information is available at: https://www.klipper3d.org/CONTRIBUTING.html

There are some steps that you can take now:

  1. Perform a self-review of your Pull Request by following the steps at: https://www.klipper3d.org/CONTRIBUTING.html#what-to-expect-in-a-review
    If you have completed a self-review, be sure to state the results of that self-review explicitly in the Pull Request comments. A reviewer is more likely to participate if the bulk of a review has already been completed.
  2. Consider opening a topic on the Klipper Discourse server to discuss this work. The Discourse server is a good place to discuss development ideas and to engage users interested in testing. Reviewers are more likely to prioritize Pull Requests with an active community of users.
  3. Consider helping out reviewers by reviewing other Klipper Pull Requests. Taking the time to perform a careful and detailed review of others work is appreciated. Regular contributors are more likely to prioritize the contributions of other regular contributors.

Unfortunately, if a reviewer does not assign themselves to this GitHub Pull Request then it will be automatically closed. If this happens, then it is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available.

Best regards,
~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.

@KevinOConnor
Copy link
Collaborator

Thanks. Can you elaborate on what hardware needs this customization? It seems unusual that there are some uc1701 chips that are so different from other uc1701 chips. Is it perhaps a different display chip entirely?

-Kevin

@VragVideo
Copy link
Author

VragVideo commented Sep 25, 2023

Can you elaborate on what hardware needs this customization? It seems unusual that there are some uc1701 chips that are so different from other uc1701 chips. Is it perhaps a different display chip entirely?

I use klipper on Alfawise Ex8 printer. This printer is version of the Anet A8. It has display with label on plate "WYH L12864 COG".
As I know this is ST7565 based LCD with a single 10-pin connector. Sorry for delay I was out of net.

@KevinOConnor
Copy link
Collaborator

Okay, thanks. If the chip is actually an ST7565 then I don't think we should add new options to the uc1701 config. Consider adding a new ST7565 definition (both to the code and the documentation). For example, you can check out how the SH1106 is implemented as a customization on the base uc1701 implementation.

-Kevin

@KevinOConnor KevinOConnor added the pending feedback Topic is pending feedback from submitter label Sep 29, 2023
@github-actions
Copy link

Unfortunately a reviewer has not assigned themselves to this GitHub Pull Request and it is therefore being closed. It is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available.

Best regards,
~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.

@github-actions github-actions bot closed this Oct 14, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pending feedback Topic is pending feedback from submitter reviewer needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants