-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
uc1701: x_offset and columns values added for uc1701 displays #6323
Conversation
Signed-off-by: Vladimir Milevski <[email protected]>
Thank you for your contribution to Klipper. Unfortunately, a reviewer has not assigned themselves to this GitHub Pull Request. All Pull Requests are reviewed before merging, and a reviewer will need to volunteer. Further information is available at: https://www.klipper3d.org/CONTRIBUTING.html There are some steps that you can take now:
Unfortunately, if a reviewer does not assign themselves to this GitHub Pull Request then it will be automatically closed. If this happens, then it is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available. Best regards, PS: I'm just an automated script, not a human being. |
Thanks. Can you elaborate on what hardware needs this customization? It seems unusual that there are some uc1701 chips that are so different from other uc1701 chips. Is it perhaps a different display chip entirely? -Kevin |
I use klipper on Alfawise Ex8 printer. This printer is version of the Anet A8. It has display with label on plate "WYH L12864 COG". |
Okay, thanks. If the chip is actually an ST7565 then I don't think we should add new options to the uc1701 config. Consider adding a new ST7565 definition (both to the code and the documentation). For example, you can check out how the SH1106 is implemented as a customization on the base uc1701 implementation. -Kevin |
Unfortunately a reviewer has not assigned themselves to this GitHub Pull Request and it is therefore being closed. It is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available. Best regards, PS: I'm just an automated script, not a human being. |
Changing x_offset and columns in the printer.cfg allows to fix artifacts like shown on image. x_offset parameter shifts picture forward and columns parameter set to 132 clear point at end of line.