-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optionally handle clone deploy needed when 'stow_on_each_sample: False' #2678
Optionally handle clone deploy needed when 'stow_on_each_sample: False' #2678
Conversation
Return the triggered state from verify_state() and update the callers to raise the error (if needed). Signed-off-by: Kevin O'Connor <[email protected]>
Simplify raise_probe() by separating out the pin_up_not_triggered case. Signed-off-by: Kevin O'Connor <[email protected]>
…lure If an error is found during the pin_up_not_triggered check, then apply the reset command for a full second (instead of just 100ms). This gives the bltouch more time to check its internal state. Signed-off-by: Kevin O'Connor <[email protected]>
Be sure to fully raise the probe prior to starting any future toolhead movements in the multi_probe_end() case. Signed-off-by: Kevin O'Connor <[email protected]>
Some clones don't raise the pin on a reset and the ANTClabs BL-Touch sometimes doesn't raise the pin either. Rework the (infrequently called) sensor test code to always issue a pin_up command before the touch command. Also, perform a reset and retry if the sensor test fails. Signed-off-by: Kevin O'Connor <[email protected]>
Signed-off-by: Kevin O'Connor <[email protected]>
Honestly, I think I would rather tell people that If we ever implement probing in touch mode, that would also be the way to go for clone probes that happen to support touch mode. |
This worked in my first testing after adding At some point in my testing, though, my probe stopped deploying which fails every attempt to home or probe now. I tried switching back to the regular branch but the problem persists there and through a power cycle of the printer. When starting the printer up now instead of getting the "down, up, down, up" test it would normally do I get a "Failed to verify BLTouch probe is raised; retrying." error in the log. I think this happened the first time I issued a PROBE_ACCURACY command with the new branch, but I'm not sure what would have caused it or why reverting the changes wouldn't correct it. Maybe my probe just gave up at an inconvenient time? |
399e227
to
5c8d15b
Compare
In case it would be helpful, here is the log from testing after my probe entered an unresponsive state. I'm guessing there isn't much to go by there. It looks like this has been closed now. I suppose there isn't much hope of my probe coming back to life. In the absence of any actual conclusion I might have to write my probe off as unfortunate timing of a dead probe. |
I'm not sure why this got closed - something odd with github handling of branches. -Kevin |
Hard to imagine. What happens if you disconnect all the wires of the probe and just give it GND and +5V? No self-test? |
Well, manually deploying the pin and issuing a |
Very interesting. So it needs a deploy before a reset when it is in a very strange state. What say you crowd fund a better clone or an original. I will put 1$ in :-)) |
Closing this is fine - I just wanted to put in some code changes for @fiferboy to test. |
Checking this branch a second time gave me the same behaviour (still recoverable). My pin was deformed from a print failure last night which I thought there was a chance of being the source of the problem. I replaced the pin with a new one and it acts even worse! The self test now ends with the probe in the deployed position (no alarm). I am going to straighten the original pin and retest everything.
Lol! This is actually my second (and more functional) clone 😆 |
Original pin straightened out and functionality looks good. Doing a PROBE_ACCURACY without the Unfortunately it is doing the exact same thing with the
This still might be to do with my whacked out pin, but using the |
This is when using the |
Oh, and the drop wouldn't be so bad if it didn't bounce, right? Does it really bounce up and down again, once or a couple of times? |
Yes, the behaviour is the same regardless of
The only thing wrong with the drop is that it seems to mess up the next probe if it comes too quickly - maybe setting a higher lift between probes would work fine. Now, this could very well be caused by something I have done - either my pin is too messed up at this point (seems to be fine other than a bit of a 'wow' in the middle), or no longer properly magnetized, or my probe has taken one hard hit too many. The only reason I don't discount the probe altogether is because of how beautifully it worked on your monolithic rewrite branch from a few months ago - probing was a dream back then (the branch that changed the timing and removed the |
I still have it and it is rebased to the current master. I have changed it such that it is a |
I agree that it doesn't make sense to complicate the code for what seems to be a single probe gone wild. I would have thought the TriangleLab probe would be fairly popular so if more people aren't having the same problem it could definitely be something about my setup. I did try the I'll give that branch another go and see if it has that same glorious behaviour or whether my probe has deteriorated to the point where this is the best I will be able to do. Thanks for your help with all this - I appreciate the time you and @KevinOConnor have put into this (and Kevin with everything else he does on top of that). |
Give me some more days to fix up the branch according to some new stuff and then we'll see. I haven't pushed it for I while. I'll tell you when |
See #2655