This repository has been archived by the owner on Jan 11, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Elytra Plugin API #24
Draft
Kiwifuit
wants to merge
18
commits into
mcs/devel
Choose a base branch
from
elytra/plugin-api
base: mcs/devel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kiwifuit
added
enhancement
New feature or request
t-elytra
Issues relating to the Elytra Backend
labels
Jan 9, 2025
Reviewer's Guide by SourceryThis pull request introduces a plugin API for Elytra, allowing developers to extend its functionality by creating custom plugins. The API is designed around a Sequence diagram for plugin loading processsequenceDiagram
participant C as Client
participant P as Plugin
participant L as Library Loader
participant SP as ServerProvider
C->>P: load(path)
activate P
P->>L: Library::new(path)
L-->>P: Library
P->>L: get_symbol('init')
L-->>P: PluginInit symbol
P->>SP: plugin_init()
SP-->>P: Box<dyn ServerProvider>
P-->>C: Plugin instance
deactivate P
Class diagram for the new Plugin API structureclassDiagram
class ServerProvider {
<<interface>>
+id() str
+name() str
+version() str
+execute()
}
class Plugin {
-plugin: Box<dyn ServerProvider>
+load(path) Result<Plugin, PluginError>
}
class PluginError {
<<enumeration>>
Load(Error)
}
Plugin *-- ServerProvider : contains
Plugin ..> PluginError : uses
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Introduce a plugin API for Elytra, enabling external providers to be loaded dynamically at runtime.
New Features:
Tests: