Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump vtkjs #688

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Bump vtkjs #688

wants to merge 4 commits into from

Conversation

bnmajor
Copy link
Collaborator

@bnmajor bnmajor commented May 11, 2023

and set rendering backend to WebGL

@bnmajor bnmajor requested a review from thewtex May 11, 2023 17:54
Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @bnmajor thank you!

@PaulHax is going to review / merge.

@PaulHax
Copy link
Collaborator

PaulHax commented May 12, 2023

Good stuff.

Was getting a structuredClone not defined error after npm run test:debug. Upgrading puppateer to "puppeteer": "^20.2.0", upgrades the Chrome version used in the test and it passes.

@bnmajor Can you bump puppeteer and and push?

Looks like there is a bug in VTK.js after changing the volume blend mode. Kitware/vtk-js#2830
I'ed vote to not hold this PR for that fix.

@bnmajor
Copy link
Collaborator Author

bnmajor commented May 12, 2023

Thanks @PaulHax! Puppeteer has been bumped

@PaulHax
Copy link
Collaborator

PaulHax commented May 12, 2023

Gaw. Another ask. CI test job is failing at the same test as npm run debug with the old puppeteer (just after 41 reset cropping planes.) Suspect that is because the Chrome version in the test docker is old.

Can we avoid increasing the vtk.js version and just specify WebGL and does that fix the issue?

@bnmajor
Copy link
Collaborator Author

bnmajor commented May 12, 2023

@PaulHax We can skip the vtk.js bump but it doesn't look like it fixes anything - my local tests are still failing here with the following:

caught (in promise) TypeError: Cannot create proxy with a non-object as target or handler
    at publicAPI.get3DContext (index.js:287:12)
    at publicAPI.initialize (index.js:170:33)
    at publicAPI.buildPass (index.js:161:17)
    at publicAPI.apply (index.js:44:7)
    at publicAPI.traverse (index.js:32:15)
    at publicAPI.traverse (index.js:26:14)
    at publicAPI.traverseAllPasses (index.js:1213:35)
    at forceRender (index.js:452:19)
    at publicAPI.render (index.js:899:7)
    at publicAPI.initialize (index.js:148:15)

Looks like model.defaultToWebgl2 and webgl2Supported return true but model.canvas.getContext('webgl2'/'webgl'/'experimental-webgl', options) are all returning null. FWIW this is the same error I am getting with the version bump.

@PaulHax
Copy link
Collaborator

PaulHax commented May 12, 2023

OK, thanks for checking.

looks like adding a puppeteer config file actually gets the CI tests running. But they failing for the usual mysterious reasons. I am looking into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants