-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump vtkjs #688
base: master
Are you sure you want to change the base?
Bump vtkjs #688
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff. Was getting a @bnmajor Can you bump puppeteer and and push? Looks like there is a bug in VTK.js after changing the volume blend mode. Kitware/vtk-js#2830 |
Thanks @PaulHax! Puppeteer has been bumped |
Gaw. Another ask. CI test job is failing at the same test as Can we avoid increasing the vtk.js version and just specify WebGL and does that fix the issue? |
@PaulHax We can skip the vtk.js bump but it doesn't look like it fixes anything - my local tests are still failing here with the following:
Looks like |
OK, thanks for checking. looks like adding a puppeteer config file actually gets the CI tests running. But they failing for the usual mysterious reasons. I am looking into it. |
and set rendering backend to WebGL