Offscreen views #501
Draft
Offscreen views #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Separating the interaction container and the rendering container currently results in one resizeobserver (on the interaction el) to trigger a resize on the rendering el, but then that in turn triggers rendering el resize listeners (nested resizeobserver). setTimeout in resize() is a workaround.
✅ Deploy Preview for volview-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Still happens - but maybe less often... 
|
|
The canvas loss can stem from various root issues. Here's what we found on the OHIF side: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Views are rendered offscreen and kept persistent across layout changes. This should speed up layout changes and hopefully reduce potential webgl context losses from (theoretical) rapid unmount/mount of the rendering container.
Instead of having interaction and rendering occur on a single canvas, rendering is now performed on a dedicated offscreen canvas. Pixels are copied over from the rendering canvas to the interaction canvas, and interaction events are handled appropriately.
@aylward please test this out to see if it helps with context loss issues.