Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX DICOMWeb fixes #382

Merged
merged 5 commits into from
Aug 3, 2023
Merged

UX DICOMWeb fixes #382

merged 5 commits into from
Aug 3, 2023

Conversation

PaulHax
Copy link
Collaborator

@PaulHax PaulHax commented Aug 1, 2023

UX fixes for DICOMWeb feature

  • Even if DICOMWeb host was configured, its panel in the DataBrowser was minimized. Fixed
  • Fix quick showing of "No patients found message" upon initial querying of DICOMWeb server.
  • Fix saving URL parameter or env variable to DICOMWeb host local storage key. Was strange to still have a host configured after removing the URL parameter.
  • If deep linking to study/series, expand panels in DataBrowser. Patient and study sections were minimized until clicked on before.

@netlify
Copy link

netlify bot commented Aug 1, 2023

Deploy Preview for volview-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit f105a18
🔍 Latest deploy log https://app.netlify.com/sites/volview-dev/deploys/64cc0ef9dc6546000848cfeb
😎 Deploy Preview https://deploy-preview-382--volview-dev.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@PaulHax PaulHax changed the title DICOMWeb fixes UX DICOMWeb fixes Aug 1, 2023
@floryst
Copy link
Collaborator

floryst commented Aug 3, 2023

LGTM! You can merge after updating the branch.

@PaulHax
Copy link
Collaborator Author

PaulHax commented Aug 3, 2023

I don't have permission to merge.

@PaulHax PaulHax merged commit f5fd879 into Kitware:main Aug 3, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants