Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for timestamp format "HH:mm:ss,fff" #373

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chausner
Copy link

Changes proposed in this pull request:

  • Add support for timestamps in format HH:mm:ss,fff

Rationale: timestamps with a dot as decimal separator (HH:mm:ss.fff) are already supported. However, in ISO8601, the comma is the recommended decimal separator:

[...] the decimal fraction shall be divided from the integer part by the decimal sign specified in ISO 31-0, i.e. the comma [,] or full stop [.]. Of these, the comma is the preferred sign.

Our software uses HH:mm:ss,fff today and we would prefer keeping this format since it's recommended by ISO rather than changing it for compatibility with Tailviewer.

Any expected problems concerning backwards compatibility of existing plugins?
No

Any expected problems concerning backwards compatibility of existing user settings?
No

Does this break existing user workflows?
No

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants