Loft uses kw arguments #4757
Merged
Loft uses kw arguments #4757
+4,128
−173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
adamchalmers
commented
Dec 11, 2024
src/wasm-lib/kcl/src/std/loft.rs
Outdated
| /// vDegree = 2, | ||
| /// }) | ||
| /// loft([squareSketch, circleSketch0, circleSketch1], | ||
| /// baseCurveIndex: 0, |
There was a problem hiding this comment.
Had to remove comments due to #4763
adamchalmers
force-pushed
the
achalmers/kw-fn-loft
branch
from
bb0d86b to
6c4916e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4757 +/- ##
==========================================
+ Coverage 85.97% 86.02% +0.04%
==========================================
Files 84 84
Lines 30016 30036 +20
==========================================
+ Hits 25807 25837 +30
+ Misses 4209 4199 -10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
adamchalmers
force-pushed
the
achalmers/kw-fn-loft
branch
from
2bef856 to
37df72e
Compare
adamchalmers
force-pushed
the
achalmers/kw-fn-loft
branch
from
37df72e to
e3d4e53
Compare
jtran
reviewed
Dec 12, 2024
adamchalmers
force-pushed
the
achalmers/kw-fn-loft
branch
from
7a82c1b to
2e82e8b
Compare
adamchalmers
force-pushed
the
achalmers/kw-fn-loft
branch
from
a88584b to
4a17609
Compare
adamchalmers
force-pushed
the
achalmers/kw-fn-loft
branch
from
4a17609 to
a1509f4
Compare
jtran
reviewed
Dec 13, 2024
| @@ -2539,6 +2539,7 @@ fn fn_call_kw(i: &mut TokenSlice) -> PResult<Node<CallExpressionKw>> { | |||
| let initial_unlabeled_arg = opt((expression, comma, opt(whitespace)).map(|(arg, _, _)| arg)).parse_next(i)?; | |||
| let args = labeled_arguments(i)?; | |||
| ignore_whitespace(i); | |||
| opt(comma_sep).parse_next(i)?; | |||
adamchalmers
force-pushed
the
achalmers/kw-fn-loft
branch
from
a1509f4 to
3e10246
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #4600