fix: calendar not updating on month change #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit implements a new scheduleUpdate function, that schedules itself every day at 00:05. This commit also replaces the reloadDom function with the update function. There is no need to check if now > this.midnight.
The check if moment() > this.midnight is not necessary. getDom should always get the dom, no matter what time it is. This is also one reason why the issue KirAsh4#2 exists. Also this commits changes some strange usages of moment() and removes unused code.
|
I've been affected by this bug, thank you for fixing it. Trying out your branch going forward. Too bad it seems this project isn't very active anymore :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I checked your code and fixed #2
Proof that it works: https://gfycat.com/helpfulgenerousemperorpenguin