Skip to content
This repository has been archived by the owner on Aug 4, 2024. It is now read-only.

Fix ci & remove dead code #51

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Fix ci & remove dead code #51

merged 2 commits into from
Oct 12, 2023

Conversation

lewiszlw
Copy link
Member

What problem does this PR solve?

Fix ci & remove dead code

What is changed and how it works?

Code changes

  • Has Rust code change
  • Has CI related scripts change

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Note for reviewer

@KKould KKould self-requested a review October 12, 2023 18:36
@KKould KKould added the invalid This doesn't seem right label Oct 12, 2023
KKould
KKould approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@KKould KKould left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@KKould KKould merged commit 0dff115 into KipData:master Oct 12, 2023
4 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@KKould KKould KKould approved these changes

Assignees

@lewiszlw lewiszlw

Labels
invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lewiszlw @KKould