Refactor server #50
Refactor server #50
Conversation
| } | ||
| /// TODO need refactor | ||
| // #[inline] | ||
| // async fn join(&self, vec_cmd: Vec<CommandData>) -> Result<Vec<Option<Vec<u8>>>> {} |
There was a problem hiding this comment.
Why not implement this function
There was a problem hiding this comment.
The return type of this function is not reasonable. For batch operations, we should tell client which part succeed and which part failed.
There was a problem hiding this comment.
The return type of this function is not reasonable. For batch operations, we should tell client which part succeed and which part failed.
refer to the use of futures::try_join method, either all succeed at once, or all fail.
| } | ||
| /// TODO need refactor | ||
| // #[inline] | ||
| // async fn join(&self, vec_cmd: Vec<CommandData>) -> Result<Vec<Option<Vec<u8>>>> {} |
There was a problem hiding this comment.
Why not implement this function
| } | ||
| /// TODO need refactor | ||
| // #[inline] | ||
| // async fn join(&self, vec_cmd: Vec<CommandData>) -> Result<Vec<Option<Vec<u8>>>> {} |
There was a problem hiding this comment.
The return type of this function is not reasonable. For batch operations, we should tell client which part succeed and which part failed.
refer to the use of futures::try_join method, either all succeed at once, or all fail.
|
|
||
| package kipdb; | ||
|
|
||
| service KipdbRpc { |
|
Can you add some RPC related descriptions to README.md please? |
|
I think the |
like users are required to install |
|
Join remove will be put in follow up pr. |
What problem does this PR solve?
Refactor server
Issue link: #47
What is changed and how it works?
Code changes
Check List
Tests
Side effects
Note for reviewer