Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Default, constraints of CreateTable and Fix #103

Merged
merged 8 commits into from
Nov 27, 2023
Merged

Conversation

KKould
Copy link
Member

@KKould KKould commented Nov 24, 2023

What problem does this PR solve?

Support:

  • Default Value
    • e.g. create table t1(id int primary key, v1 bigint default 233)
  • Constraints of CreateTable
    • e.g. PRIMARY KEY (column_1)
    • e.g. UNIQUE (column_1, column_2, ...)
  • Cast() Function
    • e.g. select cast(c1 as varchar) from t1
  • if not exits for CreateTable

Fix:

  • Supplementary primary key as index
  • The scope aggregation of Or BinaryOperator is ignored, resulting in errors when processing and and or exist.

Perf:

  • Updated version of KipDB to use Level 0 memoization to improve overall performance
  • remove table_name of ColumnCatalog

Issue link: #97

Code changes

  • Has Rust code change
  • Has CI related scripts change

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Note for reviewer

This was referenced Nov 24, 2023
@KKould KKould self-assigned this Nov 24, 2023
@KKould KKould added enhancement New feature or request bug Something isn't working invalid This doesn't seem right labels Nov 24, 2023
@KKould KKould linked an issue Nov 25, 2023 that may be closed by this pull request
@KKould KKould requested a review from guojidan November 27, 2023 03:07
@KKould KKould merged commit e7dbac1 into KipData:main Nov 27, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a new table with an existing table name
1 participant