Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the executor to support transaction detachment #82

Merged
merged 4 commits into from
Oct 10, 2023

Conversation

KKould
Copy link
Member

@KKould KKould commented Oct 6, 2023

What problem does this PR solve?

Issue link: #74

What is changed and how it works?

Convert KipSQL's original Storage-based execution mode to Transaction-based

Code changes

  • Has Rust code change
  • Has CI related scripts change

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Note for reviewer

This PR pave the way for Begin/Commit/Rollback

@KKould KKould requested a review from loloxwg October 6, 2023 21:04
@KKould KKould self-assigned this Oct 6, 2023
@KKould KKould added enhancement New feature or request invalid This doesn't seem right labels Oct 6, 2023
@KKould KKould mentioned this pull request Oct 6, 2023
1 task
@KKould KKould changed the title refactor: refactor the executor to support transaction detachment Refactor the executor to support transaction detachment Oct 6, 2023
@lewiszlw lewiszlw mentioned this pull request Oct 9, 2023
9 tasks
self._execute(storage.clone())
impl<T: Transaction> Executor<T> for Truncate {
fn execute(self, transaction: &RefCell<T>) -> BoxedExecutor {
unsafe { self._execute(transaction.as_ptr().as_mut().unwrap()) }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6

@KKould KKould requested a review from lewiszlw October 10, 2023 10:04
@KKould KKould merged commit 8786f0f into KipData:main Oct 10, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants