Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support text column creation #77

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Support text column creation #77

merged 1 commit into from
Oct 5, 2023

Conversation

lewiszlw
Copy link
Member

@lewiszlw lewiszlw commented Oct 4, 2023

What problem does this PR solve?

Support text column in create table sql.
Part fixes #72

What is changed and how it works?

Code changes

  • Has Rust code change
  • Has CI related scripts change

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Note for reviewer

@KKould KKould requested review from KKould and loloxwg and removed request for KKould October 4, 2023 18:12
@KKould KKould added the enhancement New feature or request label Oct 4, 2023
loloxwg
loloxwg approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@loloxwg loloxwg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@loloxwg loloxwg merged commit 71c6295 into KipData:main Oct 5, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loloxwg loloxwg loloxwg approved these changes

@KKould KKould Awaiting requested review from KKould

Assignees

@lewiszlw lewiszlw

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Text type
3 participants
@lewiszlw @loloxwg @KKould