Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed and added multiple e2e tests #70

Merged
merged 9 commits into from
Sep 30, 2023
Merged

Fixed and added multiple e2e tests #70

merged 9 commits into from
Sep 30, 2023

Conversation

KKould
Copy link
Member

@KKould KKould commented Sep 30, 2023

What is changed and how it works?

add test:

  • aggregation.slt
  • basic_test.slt
  • count.slt
  • create.slt
  • delete.slt
  • distinct.slt
  • filter.slt
  • filter_null.slt
  • group_by.slt
  • having.slt
  • join.slt
  • order_by.slt

fix bug:

  • ScalarExpression::eval_column panics when there is no corresponding field
  • ScalaExpression::output_columns supports Unary
  • Conflict between aggregate functions and aliases
    • When Filter passes Aggregates into Tuple, the alias is passed through, resulting in the inability to find the corresponding field.(on ScalaExpression::eval_column L52)
      • e.g. select count(x) as a, y + 1 as b from test group by b having b + 1 = 24;
  • ScalaExpression::simplify folding errors for multiple layers of consecutive four arithmetic operations
    • e.g. select * from t1 where 24 < (-1 - c1) + 1
  • BinderContext.agg_calls has repeat
    • e.g. select sum(v1) as a, v2 from t group by v2 order by a

Code changes

  • Has Rust code change
  • Has CI related scripts change

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Note for reviewer

@KKould KKould self-assigned this Sep 30, 2023
@KKould KKould added the enhancement New feature or request label Sep 30, 2023
@KKould
Copy link
Member Author

KKould commented Sep 30, 2023

Extract merges for release builds

@KKould KKould merged commit 036385d into KipData:main Sep 30, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant