Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perf/tpcc #254

Merged
merged 2 commits into from
Dec 8, 2024
Merged

Perf/tpcc #254

merged 2 commits into from
Dec 8, 2024

Conversation

KKould
Copy link
Member

@KKould KKould commented Dec 8, 2024 •
edited
Loading

What problem does this PR solve?

  • Tuple id to use mapping to get the primary key
  • Executor uses *mut Transaction to avoid materialization problems caused by mutable references
  • simplify HashJoin and HashAgg implementation

tpmc 6669 -> 7345

ref: #247

Code changes

  • Has Rust code change
  • Has CI related scripts change

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Note for reviewer

@KKould KKould added the enhancement New feature or request label Dec 8, 2024
@KKould
perf: tpcc
cc095a0 
- `Tuple` id to use mapping to get the primary key
- `Executor` uses `*mut Transaction` to avoid materialization problems caused by mutable references
@KKould KKould merged commit 9f8a58f into main Dec 8, 2024
6 checks passed
@KKould KKould deleted the perf/tpcc branch December 8, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@KKould