Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/prepare statment #249

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Feat/prepare statment #249

merged 2 commits into from
Nov 26, 2024

Conversation

KKould
Copy link
Member

@KKould KKould commented Nov 26, 2024

What problem does this PR solve?

https://en.wikipedia.org/wiki/Prepared_statement

let statement = fnck_sql.prepare("select * from t1 where b > ?1")?;

let (_, tuples) = fnck_sql.execute(&statement, vec![("?1", DataValue::Int32(Some(0)))])?;

Code changes

  • Has Rust code change
  • Has CI related scripts change

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Note for reviewer

@KKould KKould mentioned this pull request Nov 26, 2024
6 tasks
@KKould KKould merged commit 874529a into main Nov 26, 2024
6 checks passed
@KKould KKould deleted the feat/prepare_statment branch December 8, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant