Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: impl ReferenceSerialization #230

Merged
merged 3 commits into from
Oct 17, 2024
Merged

Conversation

KKould
Copy link
Member

@KKould KKould commented Oct 16, 2024

What problem does this PR solve?

In order to maintain the consistency of Column, implement ReferenceSerialization to prevent Column from being serialized directly.

  • Use the derive macro to automatically generate relevant ReferencSerialization code to override LogicPlan
  • Implementation of ColumnId using Ulid
  • Insert supports different mapping methods (Select Into is name, Insert Into is column id)

Code changes

  • Has Rust code change
  • Has CI related scripts change

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Note for reviewer

@KKould KKould added the enhancement New feature or request label Oct 16, 2024
@KKould KKould self-assigned this Oct 16, 2024
@KKould KKould force-pushed the refactor/reference_serializtion branch from e589f08 to 1853027 Compare October 17, 2024 16:19
@KKould KKould force-pushed the refactor/reference_serializtion branch from 5dd1d23 to fa99511 Compare October 17, 2024 17:40
@KKould KKould merged commit d584167 into main Oct 17, 2024
6 checks passed
@KKould KKould deleted the refactor/reference_serializtion branch November 10, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant