Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: impl ReferenceSerialization #227

Merged
merged 3 commits into from
Oct 7, 2024
Merged

Conversation

KKould
Copy link
Member

@KKould KKould commented Oct 7, 2024

What problem does this PR solve?

ReferenceSerialization is used to unify meta-information such as ColumnRef to avoid possible inconsistencies caused by direct serialization after deserialization.

Code changes

  • Has Rust code change
  • Has CI related scripts change

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Note for reviewer

@KKould KKould added the enhancement New feature or request label Oct 7, 2024
@KKould KKould self-assigned this Oct 7, 2024
@KKould KKould force-pushed the refactor/reference_serialization branch 2 times, most recently from ff3954f to 71e90f2 Compare October 7, 2024 17:59
@KKould KKould force-pushed the refactor/reference_serialization branch from 71e90f2 to 5e00745 Compare October 7, 2024 18:09
@KKould KKould force-pushed the refactor/reference_serialization branch from a35cd67 to 8ba1b78 Compare October 7, 2024 18:40
@KKould KKould merged commit 770b505 into main Oct 7, 2024
4 of 6 checks passed
@KKould KKould deleted the refactor/reference_serialization branch October 16, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant