Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: strip table_cache and meta_cache out of storage & optimize … #214

Merged
merged 1 commit into from
Aug 18, 2024
Merged

perf: strip table_cache and meta_cache out of storage & optimize … #214

merged 1 commit into from
Aug 18, 2024

Conversation

KKould
Copy link
Member

@KKould KKould commented Aug 17, 2024

…RocksIter

What problem does this PR solve?

  • remove Transaction::table_cache & Transaction::meta_cache
  • fix RocksIter's judgment of upper, extract and return None to avoid redundant reading in IndexIter

Code changes

  • Has Rust code change
  • Has CI related scripts change

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Note for reviewer

@KKould KKould added invalid This doesn't seem right perf labels Aug 17, 2024
@KKould KKould self-assigned this Aug 17, 2024
@KKould KKould merged commit 811d182 into main Aug 18, 2024
6 checks passed
@KKould KKould deleted the perf/rocks_iter branch August 27, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@KKould KKould

Labels
invalid This doesn't seem right perf
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@KKould