Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/remove async #212

Merged
merged 4 commits into from
Aug 7, 2024
Merged

Refactor/remove async #212

merged 4 commits into from
Aug 7, 2024

Conversation

KKould
Copy link
Member

@KKould KKould commented Aug 7, 2024

What problem does this PR solve?

  • remove async api
  • replace kipdb to rocksdb
  • implemented using feature coroutines as executor

Code changes

  • Has Rust code change
  • Has CI related scripts change

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Note for reviewer

@KKould KKould added the invalid This doesn't seem right label Aug 7, 2024
@KKould KKould self-assigned this Aug 7, 2024
@KKould KKould merged commit a9e799e into main Aug 7, 2024
6 checks passed
loloxwg
loloxwg reviewed Aug 7, 2024
View reviewed changes
Copy link
Member

@loloxwg loloxwg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

@KKould KKould deleted the refactor/remove_async branch August 27, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loloxwg loloxwg loloxwg left review comments

Assignees

@KKould KKould

Labels
invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KKould @loloxwg