Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: decoupling kipdb::TransactionIter #198

Merged
merged 2 commits into from
Apr 5, 2024
Merged

style: decoupling kipdb::TransactionIter #198

merged 2 commits into from
Apr 5, 2024

Conversation

KKould
Copy link
Member

@KKould KKould commented Apr 5, 2024

What problem does this PR solve?

I tried to use redb as the new storage engine. Although it failed, it removed the coupling of kipdb.

Code changes

  • Has Rust code change
  • Has CI related scripts change

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Note for reviewer

@KKould KKould requested a review from crwen April 5, 2024 07:38
@KKould KKould self-assigned this Apr 5, 2024
@KKould KKould added the invalid This doesn't seem right label Apr 5, 2024
crwen
crwen approved these changes Apr 5, 2024
View reviewed changes
Copy link
Member

@crwen crwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, there are so many default implements in Transaction

@KKould
Copy link
Member Author

KKould commented Apr 5, 2024

oh, there are so many default implements in Transaction

yep, to avoid code duplication when supporting new storage engines

@KKould KKould merged commit b1c7928 into KipData:main Apr 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crwen crwen crwen approved these changes

Assignees

@KKould KKould

Labels
invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KKould @crwen