feat: support Octets
for Char/Varchar
#184
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Tips: originally,
LogicalType::Char
/LogicalType::Varchar
could get the exact value in theLogicalType::raw_len
method, but now only Octet's Char/Varchar is allowed to be returned, because only Octet determines the number of Bytes, while Character only limits the number of characters. In utf8, The minimum number of bytes of 4 characters is 4 and the maximum is 16(undetermined number of bytes)What is changed and how it works?
Code changes
Check List
Tests
Side effects
Note for reviewer