Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support Expression on Default #180

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Conversation

KKould
Copy link
Member

@KKould KKould commented Mar 25, 2024

What problem does this PR solve?

prefix function of CURRENT_DATE on SQL 2016

e.g.
on udf test
function: test(arg1, arg2)
CREATE TABLE test (id int primary key, c1 int, c2 int default test(1, 2));

Issue link:

What is changed and how it works?

Code changes

  • Has Rust code change
  • Has CI related scripts change

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Note for reviewer

@KKould KKould requested a review from crwen March 25, 2024 08:02
@KKould KKould self-assigned this Mar 25, 2024
@KKould KKould added the enhancement New feature or request label Mar 25, 2024
@KKould KKould changed the title feat: support 'Expression' on Default feat: support Expression on Default Mar 25, 2024
@KKould KKould merged commit a90f94b into KipData:main Mar 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants